topology2: Enable ChainDMA for HDMI by default#8568
Merged
kv2019i merged 2 commits intothesofproject:mainfrom Dec 5, 2023
Merged
topology2: Enable ChainDMA for HDMI by default#8568kv2019i merged 2 commits intothesofproject:mainfrom
kv2019i merged 2 commits intothesofproject:mainfrom
Conversation
In practice all HDA links (on LNL SDW/SSP/DMIC also) can use ChainDMA, but the flag is used to enable this only for display links. Rename the flag to be precise about this. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
kv2019i
approved these changes
Dec 4, 2023
lgirdwood
approved these changes
Dec 4, 2023
plbossart
reviewed
Dec 4, 2023
ujfalusi
force-pushed
the
peter/pr/enable_hdmi_chaindma_01
branch
from
54879a4 to
24465e8
Compare
Make the HDMI_USE_CHAIN_DMA set to true by default as enabling it for every configuration just does not scale. The generic HDA topologies enabled this for all IPC4 platforms already. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Contributor
Author
|
Changes since v1:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
going through all configurations and set the flag one-by-one does not scale and the HDA topologies have the ChainDMA enabled for HDMI for quite some time now while some SDW enables it, some does not.
It can be selectively disabled for configurations if needed, but ChainDMA should be stable now to be default on display side.
Replaces: #8527