Skip to content

Conversation

@singalsu
Copy link
Collaborator

@singalsu singalsu commented Jun 3, 2024

No description provided.

@singalsu singalsu marked this pull request as ready for review June 3, 2024 16:24
@cujomalainey
Copy link
Contributor

If this is part of a larger migration of code can you link a top-level bug?

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu I know why you are doing this, but I would not figure this out from the commit messages. Please add a brief comment why this move is made, especially as this is first of its kind.

@singalsu
Copy link
Collaborator Author

singalsu commented Jun 4, 2024

If this is part of a larger migration of code can you link a top-level bug?

Yes, I'll add the reason to commit message. The purpose is to collect all module rated into same directory for easier access. Same has been already done for kconfig and IPC4 .toml. The functionality is not changed, though I added some checks for file opens since moving the files with triggered some fopen() errors with old paths.

@singalsu singalsu force-pushed the move_tune_dcblock branch from 9ba206e to a23036c Compare June 4, 2024 16:22
end

addpath ./../common
dcblock_paths(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, false and true are available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use them then, makes it a bit clearer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I will update this, now busy with another topic but soon!

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu I guess we need to set the PATH for matlab to find files/functions that are not in the current dir ? Btw, does Matlab/Octave has a default set of directories it uses for functions ?

@singalsu
Copy link
Collaborator Author

@singalsu I guess we need to set the PATH for matlab to find files/functions that are not in the current dir ? Btw, does Matlab/Octave has a default set of directories it uses for functions ?

Yep, there's functions addpath and rmpath for it. The default path is just current directory and Matlab/Octave internal toolboxes paths. The user can also alter paths via .matlabrc and .octaverc.

@lgirdwood lgirdwood added this to the v2.11 milestone Jun 25, 2024
The change is done to consolidate the files belonging to the
module. This patch only moves the files to a new location.
Successive patches address the issues caused by this move.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
A function dcblock_paths.m is added to handle add and remove
of path.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The paths for exported blobs for topology and for sof-ctl need
to be fixed after directory move.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch renames with prefix sof_ all the top level functions
for dcblock blobs design.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@lgirdwood lgirdwood merged commit 7ed55e5 into thesofproject:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants