-
Notifications
You must be signed in to change notification settings - Fork 349
Audio: DCblock: Tune: Move dcblock setup scripts to module directory #9184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If this is part of a larger migration of code can you link a top-level bug? |
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@singalsu I know why you are doing this, but I would not figure this out from the commit messages. Please add a brief comment why this move is made, especially as this is first of its kind.
Yes, I'll add the reason to commit message. The purpose is to collect all module rated into same directory for easier access. Same has been already done for kconfig and IPC4 .toml. The functionality is not changed, though I added some checks for file opens since moving the files with triggered some fopen() errors with old paths. |
9ba206e to
a23036c
Compare
| end | ||
|
|
||
| addpath ./../common | ||
| dcblock_paths(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, false and true are available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use them then, makes it a bit clearer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I will update this, now busy with another topic but soon!
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@singalsu I guess we need to set the PATH for matlab to find files/functions that are not in the current dir ? Btw, does Matlab/Octave has a default set of directories it uses for functions ?
Yep, there's functions addpath and rmpath for it. The default path is just current directory and Matlab/Octave internal toolboxes paths. The user can also alter paths via .matlabrc and .octaverc. |
The change is done to consolidate the files belonging to the module. This patch only moves the files to a new location. Successive patches address the issues caused by this move. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
A function dcblock_paths.m is added to handle add and remove of path. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The paths for exported blobs for topology and for sof-ctl need to be fixed after directory move. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch renames with prefix sof_ all the top level functions for dcblock blobs design. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
a23036c to
8264c26
Compare
No description provided.