Use the new SubTreeCopy feature in the topology2 compiler #9354
Conversation
Modify the route description to an array in preparation for allowing class extensions to define new classes where existing routes will be merged with the new routes in the sub classes. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Add a new pipeline, mixout-gain-eqiir-eqfir, that uses the new alsa-utils topology feature to allow extending existing pipeline definitions. This new class extends the base class mixout-gain-dai-copier-playback class by adding the eqiir & eqfir widgets along with the new routes. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Modify the class definitions for the mixout-gain-efx-dai-copier-playback and the mixout-gain-efx-mbdrc-dai-copier-playback pipelines to use the SubreeCopy feature to extend the mixout-gain-eqiir-eqfir pipeline class definition. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
It's already done @plbossart |
|
@ranj063 |
|
@wszypelt did you update the docker tools in the CI system? It's expected to fail if you try to build the updated topology without the updated tools. |
|
New docker image is updated in Aug 6th. |
|
@lgirdwood we still need time to update docker, I'll let you know as soon as I get it done |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Sorry, took a bit long to review, but looks good to me. The syntax will take some to get used to, but these examples will help with that. Would be good to have ack from @singalsu as this is modifying the efx development tplgs.
| Object.Control.bytes."1" { | ||
| IncludeByKey.EFX_IIR_PARAMS { | ||
| "passthrough" "include/components/eqiir/passthrough.conf" | ||
| SubTreeCopy.baseclass { |
There was a problem hiding this comment.
It would be nice to have some alsa-conf language version. The error you get now when building with too old alsa-utils is not very user-friendyl.
There was a problem hiding this comment.
@kv2019i but this doesnt add anything new in alsaconf. All changes are limited to alsatopology but we dont have versioning for that though
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
Nice work! This worked perfectly when I tried with new build of sof-hda-efx-generic-4ch.tplg.
|
Ready to go once Intel CI System has updated topology toolchain. |
|
@ranj063 @fredoh9 @lgirdwood @kv2019i @plbossart docker at Intel Ci system has been updated :) |
7 participants
Use the new feature in the topology compiler to extend the base class definitions to modify the pipelines that simply extend the pipeline with one or more widgets.