ipc3: add subsize check #9374
ipc3: add subsize check #9374
Conversation
cujomalainey
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
|
Hmm looks like the CI found some issues. Going to check if this is a test issue or check bug. |
|
@singalsu @RanderWang the FIR init config for cmocka is invalid. 146 * 4 = 584. This violates IPC3 |
|
Same story for the testbench, config of 616 being passed into the priv config for FIR. |
@singalsu are you able to fix the mock ? Thanks !! |
Yep, I will. Good catch @cujomalainey ! |
|
@cujomalainey @lgirdwood The fix for FIR unit test is in #9391. |
|
Moving back to draft to prevent merge until #9391 is resolved |
cujomalainey
requested review from
marcinszkudlinski and
pblaszko
as code owners
The ext size is counted as part of the ipc header size. The process size and header size need to be less than the ipc max size. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
|
Rebased on top of the submitted version of #9402 cmocka and testbench should come back clean |
|
@wszypelt what is the story on CI? |
|
@cujomalainey problem with one machine on CI, but fixed and from what I see tests are already on pass |
5 participants
I missed a case where the process size should be less than the ext size. Fuzzer found the loophole and had some fun.