Skip to content

Conversation

@singalsu
Copy link
Collaborator

This patch adds to "scripts/rebuild-testbench.sh -p ptl" option to test processing components with PTL ACE3.0 DSP build.

@singalsu singalsu marked this pull request as ready for review August 29, 2024 10:34
@singalsu singalsu requested a review from marc-hb as a code owner August 29, 2024 10:34
@singalsu singalsu requested review from kv2019i and lgirdwood August 29, 2024 10:35
TOOLCHAIN_VER="RI-2022.10-linux"
;;
ptl)
PLATFORM="$platform"
Copy link
Collaborator

@marc-hb marc-hb Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do everyone a favor and make this the default just before the case in a first, cleanup commit? Overriding it only when different.

This should get rid of almost 20 lines.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done now!

This script is used to get detailed build parameters for
testbench-xt version build. The PLATFORM is in most cases
the same as the platform name in build command line so it
can be set as default. Only the cases when the name
is different need to be preserved.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds to "scripts/rebuild-testbench.sh -p ptl" option
to test processing components with PTL ACE3.0 DSP build.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once mandatory CI show pass.

@kv2019i kv2019i merged commit 828b450 into thesofproject:main Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants