intel: ace: Enable KCPS Dynamic Clock Control for LNL and PTL #9568
Conversation
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
tmleman
requested review from
abonislawski,
marcinszkudlinski,
serhiy-katsyuba-intel and
softwarecki
This patch adds definitions for the base CPS (Cycles Per Second) usage for primary and secondary cores in the `clk.h` file for the LNL platform. **Changes Include:** - Defined `PRIMARY_CORE_BASE_CPS_USAGE` as 20000. - Defined `SECONDARY_CORE_BASE_CPS_USAGE` as 10000. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
This patch adds definitions for the base CPS (Cycles Per Second) usage for primary and secondary cores in the `clk.h` file for the PTL platform. **Changes Include:** - Defined `PRIMARY_CORE_BASE_CPS_USAGE` as 20000. - Defined `SECONDARY_CORE_BASE_CPS_USAGE` as 10000. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
This patch enables the `CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL` option for the LNL platform by updating the `intel_adsp_ace20_lnl.conf` configuration file. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
This patch enables the `CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL` option for the PTL platform by updating the `intel_adsp_ace30_ptl.conf` configuration file. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
|
@kv2019i can we run bigger test scope for this on LNL/PTL? It was not easy to stabilize on MTL |
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Looks good, we just need to not use the deprecated legacy headers as they will be removed soon.
| #define PRIMARY_CORE_BASE_CPS_USAGE 20000 | ||
| #define SECONDARY_CORE_BASE_CPS_USAGE 10000 |
There was a problem hiding this comment.
This file is going to get removed as it was needed for xtos usage, can we make this a Kconfig value ?
There was a problem hiding this comment.
Probably can be in a separate PR (as the platform clk.h is already used for this purpose in mainline), but agreed this is better moved off and not add any new usage of platform layer to the codebase.
There was a problem hiding this comment.
ok, I'm good with this, we can follow up later and fix the header.
| #define PRIMARY_CORE_BASE_CPS_USAGE 20000 | ||
| #define SECONDARY_CORE_BASE_CPS_USAGE 10000 |
There was a problem hiding this comment.
Probably can be in a separate PR (as the platform clk.h is already used for this purpose in mainline), but agreed this is better moved off and not add any new usage of platform layer to the codebase.
| #define PRIMARY_CORE_BASE_CPS_USAGE 20000 | ||
| #define SECONDARY_CORE_BASE_CPS_USAGE 10000 |
There was a problem hiding this comment.
ok, I'm good with this, we can follow up later and fix the header.
5 participants
This pull request introduces the following changes to the LNL and PTL platforms:
Enable KCPS Dynamic Clock Control:
intel_adsp_ace20_lnl.confconfiguration file to enableCONFIG_KCPS_DYNAMIC_CLOCK_CONTROLfor the LNL platform.intel_adsp_ace30_ptl.confconfiguration file to enableCONFIG_KCPS_DYNAMIC_CLOCK_CONTROLfor the PTL platform.Define Base CPS Usage:
PRIMARY_CORE_BASE_CPS_USAGEandSECONDARY_CORE_BASE_CPS_USAGEin theclk.hfile for both LNL and PTL platforms.