Tools: Testbench: Fix ibs/obs calculation #9616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous ibs and obs calculate was wrong but it appeared to work since not many components use it. The issue was seen with Aria. Since the ibs depends on audio frame format and number of frames in period, the testbench parameter period_size is changed to period_frames to calculate ibs and obs in component setup. This fix is a workaround until parsing ibs/obs from topology is done to testbench. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
lgirdwood
approved these changes
Oct 25, 2024
kv2019i
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous ibs and obs calculate was wrong but it appeared to work since not many components use it. The issue was seen with Aria. Since the ibs depends on audio frame format and number of frames in period, the testbench parameter period_size is changed to period_frames to calculate ibs and obs in component setup.
This fix is a workaround until parsing ibs/obs from topology is done to testbench.