[RFC] generic effect type with fir and iir eq#68
[RFC] generic effect type with fir and iir eq#68lgirdwood merged 2 commits intothesofproject:masterfrom
Conversation
| @@ -1,43 +0,0 @@ | |||
| divert(-1) | |||
There was a problem hiding this comment.
Looks like these patches should be squashed ?
| ` tuples "'N_EQ_FIR($1)`_tuples_str_type"' | ||
| `}' | ||
| `SectionData."'N_EQ_FIR($1)`_data_bytes" {' | ||
| ` bytes "0x00,0x00,0x00,0x04,0x00,0x02,0x00,0x01,0x00,0x01,0x00,' |
There was a problem hiding this comment.
IIRC SectionData can also use files as input (i.e. it can read binary coefficients), this way we could specify the filename to the N_EQ_FIR as an argument.
There was a problem hiding this comment.
Yes we discussed with Seppo this would be better/nicer than copying octave script output here. I tested it but for some reason could not get the env var working in my shell, so alsatplg was looking the file from some /usr/foo/bar/etc. But yeah, that was the idea.
There was a problem hiding this comment.
ok, we need to patch alsatplg, sounds like a bug - we should be able to use an ENV variable or cmd line to specify "include" folders for files. This will need upstreamed to alsa dev mailing list and will need commit ID updated on our Dockerfile once merged.
There was a problem hiding this comment.
ok, this was just my stupidity, now got the file working with with ALSA_CONFIG_TPLG=.
I still have to test this, but will probably update this method
juimonen
force-pushed
the
eq_test
branch
4 times, most recently
from
a749bda to
f88d72d
Compare
|
@juimonen what is the status on this one? I believe this one is needed for thekernel patches that were merged. |
This patch adds EQ, bytecontrol, and EQ+volume pipeline m4 macros and an enhanced topology with EQ for UP2 + HiFiberry. There is not yet FIR/IIR type select. The EQ type is currently hardcoded into kernel. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
Adding type string to widget data allows the driver to identify different effects. As an example use this in the equalizer. Also modify equalizer to pass default parameters in control's private data. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
|
@ranj063 I've rebased to master. should be fine now. I can't see anymore Liam's comment, but I guess it was about merging the commits. I kept them separately because the first one was mostly Ranjani's and Seppo's work. |
4 participants
This PR has also seppo's patch which is not merged yet... So this PR concerns only the top most commit