This repository was archived by the owner on Jan 17, 2019. It is now read-only.
eqctl: do not process invalid input file name#87
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Oct 2, 2018
Merged
eqctl: do not process invalid input file name#87lgirdwood merged 1 commit intothesofproject:masterfrom
lgirdwood merged 1 commit intothesofproject:masterfrom
Conversation
Collaborator
Author
|
@lgirdwood @singalsu this fixes seg faults when input file does not exist. |
lgirdwood
suggested changes
Oct 1, 2018
| fh = fopen(setup, "r"); | ||
| if (!fh) { | ||
| fprintf(stderr, "error: invalid input file name\n"); | ||
| return -EINVAL; |
Member
There was a problem hiding this comment.
best return errno and use a more generic error message. See the fopen() man page.
Fixes seg faults when input file does not exist. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Collaborator
Author
|
@lgirdwood I've fixed the return value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes seg faults when input file does not exist.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com