This repository was archived by the owner on Jan 17, 2019. It is now read-only.
logger/rmbox: unify implementation of new logger tool with old rmbox#88
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Oct 8, 2018
Merged
Conversation
lgirdwood
suggested changes
Oct 3, 2018
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
I think we should install our UAPI ABI headers locally here and version them so that there are no conflicts with SOF. This will align with how alsa-lib works.
The FW boot message should also contain te ABI version number as part of FW ready message.
akloniex
force-pushed
the
unify-logger
branch
4 times, most recently
from
710dc76 to
ab4b8d5
Compare
lgirdwood
suggested changes
Oct 5, 2018
Integrate both tools to provide common CLI. Also provide better logging format for logger tool. Signed-off-by: ArturX Kloniecki arturx.kloniecki@linux.intel.com
Member
|
@akloniex can you send a PR to the kernel with the version info too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate both tools to provide common CLI.
Also provide better logging format for logger tool.
Signed-off-by: ArturX Kloniecki arturx.kloniecki@linux.intel.com