This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Conversation
Contributor
|
Why not just do this? |
Contributor
|
FWIW, those references are from annotated tags. |
Contributor
Author
|
Definitely cleaner; think I got confused in understanding difference between the two. |
This filters the tags we retrieve from git. Specifically we're ignoring ^{}
because they don't play nice with version metadata.
Minor change to the checkout workflow - fetch tags only instead of
entire history. Saw the example in the readme and seemed useful.
Signed-off-by: Brad Beam <brad.beam@carbonrelay.com>
jgustie
reviewed
May 8, 2020
Comment on lines
-18
to
+19
| - name: Unshallow | ||
| run: git fetch --prune --unshallow | ||
| - name: Fetch tags | ||
| run: git fetch --depth=1 origin '+refs/tags/*:refs/tags/*' |
Contributor
There was a problem hiding this comment.
Can we just leave this like it was so it matches the documentation it came from?
Contributor
Author
There was a problem hiding this comment.
Was torn on switching to tags or adding in fetch-depth: 0 to save a step.
# Number of commits to fetch. 0 indicates all history.
# Default: 1
fetch-depth: '
Contributor
There was a problem hiding this comment.
You are right, getting the tags is better then fetch-depth: 0. I think "new Git" lets you do git fetch --tags --depth=1 instead of spelling out the refspec.
jgustie
reviewed
May 8, 2020
jgustie
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This filters the tags we retrieve from git. Specifically we're ignoring ^{}
because they don't play nice with version metadata.
Minor change to the checkout workflow - fetch tags only instead of
entire history. Saw the example in the readme and seemed useful.
Signed-off-by: Brad Beam brad.beam@carbonrelay.com