Fix Accordion typo in docs navigation and route naming#559
Closed
MD-Mushfiqur123 wants to merge 2 commits into
Closed
Fix Accordion typo in docs navigation and route naming#559MD-Mushfiqur123 wants to merge 2 commits into
MD-Mushfiqur123 wants to merge 2 commits into
Conversation
- Rename directory accordian/ to accordion/ - Fix function name BlocksAccordianPage -> BlocksAccordionPage - Fix navigation ids, labels, and hrefs in both component and design-system configs - Add permanent redirect from old path to maintain backward compatibility Closes thesysdev#553
Contributor
|
Thanks @MD-Mushfiqur123, closing this in favor of #571, which has since landed for #553. Your approach (config-level redirect in next.config.mjs instead of a stub page) was actually the right call, and that's the approach now in main. Two reasons this one didn't go in directly:
Appreciate you taking a swing at this. Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #553