Skip to content

Name signals and stores#63

Merged
thetarnav merged 5 commits into
thetarnav:mainfrom
edemaine:name
Aug 11, 2022
Merged

Name signals and stores#63
thetarnav merged 5 commits into
thetarnav:mainfrom
edemaine:name

Conversation

@edemaine
Copy link
Copy Markdown
Contributor

@edemaine edemaine commented Aug 11, 2022

As requested. 😄

This is the most Babel I've done, but it was pretty fun. I tried to mimic your coding style, and cover all the import cases you were otherwise covering.

Let me know if you prefer a different plugin name or description.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 11, 2022

⚠️ No Changeset found

Latest commit: e8bf823

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thetarnav thetarnav linked an issue Aug 11, 2022 that may be closed by this pull request
@thetarnav
Copy link
Copy Markdown
Owner

Alright, I've run it with the extension, and it worked wonderfully, all signals named. Doesn't even break. I think.
Thank you so much for that. I'm very stoked to have that. Almost everyone that used the devtools was asking about why the signal names are weird like that. Well, now I not only have an answer, but a solution as well :D

@thetarnav thetarnav merged commit 2721c33 into thetarnav:main Aug 11, 2022
@github-actions github-actions Bot mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Babel plugin feature: automatically name signals/memos

2 participants