Handle semver rule #4 in ABI check (major version zero)#57
Merged
Conversation
Under semver rule #4, major version zero (0.y.z) is for initial development where anything may change. Align abi_check.sh with this: minor bump allows incompatible ABI changes, patch bump allows compatible ABI additions (formerly forbidden), and stable-version logic is unchanged.
|
coverage: 98.753%. remained the same — abi-semver-rule4 into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Under semver rule #4, major version zero (
0.y.z) is for initial development — anything may change at any time.abi_check.shpreviously applied stable-version rules unconditionally, so a0.y.zpatch bump would fail on any ABI change and breaking changes could never be allowed at all (no major bump is coming any time soon).This change adds a separate rule path for
major == 0:0.y.z→0.y.z+1): compatible ABI additions are allowed0.y.z→0.y+1.0): all ABI changes (including incompatible) are allowedmajor >= 1) are unchanged.Related Issues
Fixes # (issue number)
Type of Change
Manual Verification (Optional)
Not applicable (script logic change, verified by reading the decision table).
Checklist
docs/for any user-facing changes.mu::tinynamespace,INCLUDED_MUTINY_guards,mutiny_C-prefix)..hand.c.cpp) is required for parity.CONTRIBUTING.mdfile to ensure compliance with architectural guidelines.