verify_release is missing annotation

[jku]

verify_release:144: error: Incompatible default for argument "key_id" (default has type "None", argument has type "str")  [assignment]
verify_release:144: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True

Looks like key_id argument just requires better annotation

blocks #2169

[sanjeev98kumar]

@jku please assign me this issue, I want to do work on this issue.

[jku]

@sanjeev98kumar sure but your comment is also enough notice: thanks for volunteering!

[sanjeev98kumar]

thank you for assigning

[sanjeev98kumar]

I found the file at https://github.com/theupdateframework/python-tuf/blob/develop/verify_release#L144 but didn't get what you meant by better annotation.
What exactly is to be changed in this line?

[jku]

keyid type is str... but code that calls it also uses keyid value None, which is not of type str So I think you can do two things:

• remove the default keyid value None: we don't use the default so it's not needed
• change keyid type to Optional[str]

[sanjeev98kumar]

@jku I have fixed the issue can you please take a look and let me know if there is anything else to be done.

[jku]

Please have a look at the check failures listed on the pull request page.

CONTRIBUTING documents how to run most of the same checks locally (basically run tox) and how to fix the DCO failure.

[rogdex24]

@jku I have made a Pull Request for fixing this issue , can you please review it ?

[sanjeev98kumar]

@jku I have already made a pull request for fixing this issue.