Skip to content

Drop support for Python 3.5#1238

Merged
lukpueh merged 4 commits intotheupdateframework:developfrom
lukpueh:drop-py35
Dec 11, 2020
Merged

Drop support for Python 3.5#1238
lukpueh merged 4 commits intotheupdateframework:developfrom
lukpueh:drop-py35

Conversation

@lukpueh
Copy link
Copy Markdown
Member

@lukpueh lukpueh commented Dec 10, 2020

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #

Description of the changes being introduced by the pull request:

Python 3.5 has now reached its end-of-life and has been retired:
https://www.python.org/dev/peps/pep-0478/

The optional (but highly recommended) 'cryptography' dependency has also just dropped support for 3.5. Continuing support for 3.5 in TUF does not seem worth the effort.

This PR also updates the test configuration accordingly and recomputes the pinned dependencies.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Python 3.5 has now reached its end-of-life and has been retired.
https://www.python.org/dev/peps/pep-0478/

The optional (but highly recommended) 'cryptography' dependency
has also just dropped support for 3.5. Continuing support for 3.5
in TUF does not seem worth the effort.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Lukas Puehringer added 2 commits December 10, 2020 18:20
Also enables windows builds for the recently added Python 3.9.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
requirements-pinned.txt lists all immediate and transitive
dependencies combined for all supported Python versions.

This commit semi-automatically updates the pinned dependencies
using the instructions in requirements.txt:

Updated dependencies are:
- cryptography (supersedes dependabot's theupdateframework#1237)
- certifi (supersedes dependabot's theupdateframework#1233)
- enum34 (oddly not detected by dependabot)

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
We recently enabled support for Python 3.9 and also added
3.9 builds on appveyor, but they don't work out of the box.

Instead of troubleshooting this I suggest we soon switch to
GitHub actions:
theupdateframework#1195.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh lukpueh mentioned this pull request Dec 11, 2020
3 tasks
Copy link
Copy Markdown
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd that Dependabot didn't detect Enum, I wonder if it's not picking up dependencies which are only used on Python2?

@lukpueh
Copy link
Copy Markdown
Member Author

lukpueh commented Dec 11, 2020

... I wonder if it's not picking up dependencies which are only used on Python2?

Could be. I'll keep an eye on it.

Btw. I'm also thinking of a better way to auto-update requirements-pinned.txt (see FIXME comment in in-toto requirements docs, which are the same as for tuf/sslib). I will at least follow up with an issue shortly.

@lukpueh lukpueh merged commit c4d4362 into theupdateframework:develop Dec 11, 2020
@joshuagl
Copy link
Copy Markdown
Member

Btw. I'm also thinking of a better way to auto-update requirements-pinned.txt (see FIXME comment in in-toto requirements docs, which are the same as for tuf/sslib). I will at least follow up with an issue shortly.

Could be a good use of a scheduled GitHub action, much like securesystemlib's ed25519 check?

@lukpueh
Copy link
Copy Markdown
Member Author

lukpueh commented Dec 11, 2020

Could be a good use of a scheduled GitHub action, much like securesystemlib's ed25519 check?

Exactly what I had in mind. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants