docs: Remove academics files by rzr · Pull Request #1380 · theupdateframework/python-tuf

rzr · 2021-05-08T13:53:03Z

Those generated files are not explicitly under Apache-2.0 licence
and AFAIK they can not be regenerated from missing (latex?) sources.

To avoid licence mixup.
It would help to have those files published elsewhere.
Meanwhile online (Github) links are used.

Debian had to repack the source package to make tarball compliant with DFSG
dispite debian tools are known to be trustworthy,
this extra step would add weakess in the chain of trust

Cleanup done upstream would make distribution safer.

Bug: #1161
Bug-Debian: https://salsa.debian.org/python-team/packages/tuf/-/merge_requests/11
Relate-to: #263 (comment)
Signed-off-by: Philippe Coval rzr@users.sf.net

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #

Description of the changes being introduced by the pull request:

Please verify and check that the pull request fulfills the following
requirements:

The code follows the Code Style Guidelines
Tests have been added for the bug fix or new feature
Docs have been added for the bug fix or new feature

Those generated files are not explicitly under Apache-2.0 licence and AFAIK they can not be regenerated from missing (latex?) sources. To avoid licence mixup. It would help to have those files published elsewhere. Meanwhile online (Github) links are used. Debian had to repack the source package to make tarball compliant with DFSG despite debian tools are known to be trustworthy, this extra step would add weakess in the chain of trust Cleanup done upstream would make distribution safer. Bug: theupdateframework#1161 Bug-Debian: https://salsa.debian.org/python-team/packages/tuf/-/merge_requests/11 Relate-to: theupdateframework#263 (comment) Forwarded: theupdateframework#1380 Signed-off-by: Philippe Coval <rzr@users.sf.net>

trishankatdatadog · 2021-05-08T16:56:53Z

I don't have strong feelings, but is there a way to tell Debian package not to include certain files?

rzr · 2021-05-08T17:56:41Z

yes debian has everything to repack archive with files excluded see:

https://salsa.debian.org/python-team/packages/tuf/-/commit/d701faef3d166761993cb0d9595775ee56700e78#adb7f75f79e3bb85eb62912a2904c5d24af878fb_6_6

BTW package in NEW queue: \o/

https://ftp-master.debian.org/new/tuf_0.17.0+dfsg-1.html

jku · 2021-05-10T06:55:40Z

The idea of linking from git to a an older git commit seems fishy to me: Either we want to keep the papers somewhere or we don't.

I wonder if the papers would be a better fit for https://github.com/theupdateframework/specification/ repo?

rzr · 2021-05-10T08:48:26Z

yes That's what I suggested about relocating elsewhere,
It perfectly makes sense to have them in "specification"
because those files are statics and not tied to sources.
theupdateframework/specification#159

BTW This spec folder can also be packaged for debian unfree if there is any need.

Let me open a PR in spec repo to import theses PDFs and crosslink to this issue.

theupdateframework/specification#160

This change is part is of tuf's commit: Move all files up one directory from 'src/'. Author: vladdd <vladimir.v.diaz@gmail.com> Origin: theupdateframework/python-tuf@abf0349 Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Refactored test_replay_attack.py, changes to test_system_setup.py and renamed one of the docs. Author: Kon <akonst9@gmail.com> Origin: theupdateframework/python-tuf@bb059cd Relate-to: theupdateframework/python-tuf#1380 URL theupdateframework#159 Signed-off-by: Philippe Coval <rzr@users.sf.net>

…8.pdf This change is part is of tuf's commit: Removed doc duplicate and an obsolete test module. Author: Kon <akonst9@gmail.com> Origin: theupdateframework/python-tuf@bb059cd Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Add Diplomat paper Author: vladdd <vladimir.v.diaz@gmail.com> Origin: theupdateframework/python-tuf@e943048 Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Add Mercury paper and entry in README.rst Author: vladdd <vladimir.v.diaz@gmail.com> Origin: theupdateframework/python-tuf@fb9aa3e Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Move all files up one directory from 'src/'. Author: vladdd <vladimir.v.diaz@gmail.com> Origin: theupdateframework/python-tuf@abf0349 Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Forwarded: theupdateframework#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Refactored test_replay_attack.py, changes to test_system_setup.py and renamed one of the docs. Author: Kon <akonst9@gmail.com> Origin: theupdateframework/python-tuf@bb059cd Relate-to: theupdateframework/python-tuf#1380 URL theupdateframework#159 Forwarded: theupdateframework#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

…8.pdf This change is part is of tuf's commit: Removed doc duplicate and an obsolete test module. Author: Kon <akonst9@gmail.com> Origin: theupdateframework/python-tuf@bb059cd Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Forwarded: theupdateframework#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Add Diplomat paper Author: vladdd <vladimir.v.diaz@gmail.com> Origin: theupdateframework/python-tuf@e943048 Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Forwarded: theupdateframework#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Add Mercury paper and entry in README.rst Author: vladdd <vladimir.v.diaz@gmail.com> Origin: theupdateframework/python-tuf@fb9aa3e Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Forwarded: theupdateframework#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

…8.pdf This change is part is of tuf's commit: Removed doc duplicate and an obsolete test module. Author: Kon <akonst9@gmail.com> Origin: theupdateframework/python-tuf@e7c4352 Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Forwarded: theupdateframework#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Add Diplomat paper Author: vladdd <vladimir.v.diaz@gmail.com> Origin: theupdateframework/python-tuf@e943048 Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Forwarded: theupdateframework#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

This change is part is of tuf's commit: Add Mercury paper and entry in README.rst Author: vladdd <vladimir.v.diaz@gmail.com> Origin: theupdateframework/python-tuf@fb9aa3e Relate-to: theupdateframework/python-tuf#1380 URL: theupdateframework#159 Forwarded: theupdateframework#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

joshuagl · 2021-05-10T09:59:37Z

Even if we continue to include the PDFs in this repository, we should not include them in the Python packaging either.

My preference would be that we just keep the PDFs on the website (theupdateframework/theupdateframework.io) and not in the spec or here.

rzr · 2021-05-10T10:22:02Z

Yes duplication it source of confusion, I'll update links

Duplication is not needed since files are hosted in website project: https://github.com/theupdateframework/theupdateframework.io/tree/master/static/papers Those generated files are not explicitly under Apache-2.0 licence and AFAIK they can not be regenerated from missing (latex?) sources. To avoid licence mixup. It would help to have those files published elsewhere. Meanwhile online (Github) links are used. Debian had to repack the source package to make tarball compliant with DFSG despite debian tools are known to be trustworthy, this extra step would add weakess in the chain of trust Cleanup done upstream would make distribution safer. Bug: theupdateframework#1161 Bug-Debian: https://salsa.debian.org/python-team/packages/tuf/-/merge_requests/11 Relate-to: theupdateframework#263 (comment) Forwarded: theupdateframework#1380 Relate-to: theupdateframework/specification#160 Signed-off-by: Philippe Coval <rzr@users.sf.net>

joshuagl

Thanks for this change @rzr !

Any objections @mnm678, @trishankatdatadog ?

trishankatdatadog · 2021-05-28T21:06:41Z

Sigh, missed opportunity to install our papers on millions of Debian computers...

rzr force-pushed the sandbox/rzr/review/master branch from 005831a to 6f60cec Compare May 8, 2021 13:53

rzr changed the title ~~docs: Remove academics files~~ DRAFT: docs: Remove academics files May 10, 2021

rzr mentioned this pull request May 10, 2021

Wish: Import academics papers from tuf project theupdateframework/specification#159

Closed

rzr mentioned this pull request May 10, 2021

Import academics papers from tuf project #159 theupdateframework/specification#160

Closed

rzr force-pushed the sandbox/rzr/review/master branch from 6f60cec to a79fd90 Compare May 10, 2021 12:56

rzr changed the title ~~DRAFT: docs: Remove academics files~~ docs: Remove academics files May 24, 2021

joshuagl reviewed May 28, 2021

View reviewed changes

joshuagl approved these changes May 28, 2021

View reviewed changes

trishankatdatadog approved these changes May 28, 2021

View reviewed changes

trishankatdatadog merged commit f496c83 into theupdateframework:develop May 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Remove academics files#1380

docs: Remove academics files#1380
trishankatdatadog merged 1 commit intotheupdateframework:developfrom
CrossStream:sandbox/rzr/review/master

rzr commented May 8, 2021

Uh oh!

trishankatdatadog commented May 8, 2021

Uh oh!

rzr commented May 8, 2021 •

edited

Loading

Uh oh!

jku commented May 10, 2021

Uh oh!

rzr commented May 10, 2021 •

edited

Loading

Uh oh!

joshuagl commented May 10, 2021

Uh oh!

rzr commented May 10, 2021

Uh oh!

joshuagl left a comment

Uh oh!

trishankatdatadog commented May 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rzr commented May 8, 2021

Uh oh!

trishankatdatadog commented May 8, 2021

Uh oh!

rzr commented May 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jku commented May 10, 2021

Uh oh!

rzr commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshuagl commented May 10, 2021

Uh oh!

rzr commented May 10, 2021

Uh oh!

joshuagl left a comment

Choose a reason for hiding this comment

Uh oh!

trishankatdatadog commented May 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rzr commented May 8, 2021 •

edited

Loading

rzr commented May 10, 2021 •

edited

Loading