Skip to content

SuccinctRoles.is_delegated_role() add a test case#2039

Merged
jku merged 1 commit intotheupdateframework:developfrom
MVrachev:add-test-case
Jun 27, 2022
Merged

SuccinctRoles.is_delegated_role() add a test case#2039
jku merged 1 commit intotheupdateframework:developfrom
MVrachev:add-test-case

Conversation

@MVrachev
Copy link
Copy Markdown
Collaborator

Description of the changes being introduced by the pull request:

Add a test case when there is a bin name with the desired prefix, but
which cannot be cast to a hexadecimal number.

Signed-off-by: Martin Vrachev mvrachev@vmware.com

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Add a test case when there is a bin name with the desired prefix, but
which cannot be cast to a hexadecimal number.

Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2556102272

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.129%

Totals Coverage Status
Change from base Build 2541050218: 0.1%
Covered Lines: 1303
Relevant Lines: 1319

💛 - Coveralls

Copy link
Copy Markdown
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Looking at these two cases:

    "bin-s",
    "bin-0t",

is the difference that first one fails because of length already and second one fails at hex parsing stage?

@MVrachev
Copy link
Copy Markdown
Collaborator Author

Looks good.

Looking at these two cases:

    "bin-s",
    "bin-0t",

is the difference that first one fails because of length already and second one fails at hex parsing stage?

Yes, exactly that is the difference.

@jku jku merged commit 8a03abf into theupdateframework:develop Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants