SuccinctRoles.is_delegated_role() add a test case#2039
Merged
jku merged 1 commit intotheupdateframework:developfrom Jun 27, 2022
Merged
SuccinctRoles.is_delegated_role() add a test case#2039jku merged 1 commit intotheupdateframework:developfrom
jku merged 1 commit intotheupdateframework:developfrom
Conversation
Add a test case when there is a bin name with the desired prefix, but which cannot be cast to a hexadecimal number. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
Pull Request Test Coverage Report for Build 2556102272
💛 - Coveralls |
jku
approved these changes
Jun 27, 2022
Member
jku
left a comment
There was a problem hiding this comment.
Looks good.
Looking at these two cases:
"bin-s",
"bin-0t",
is the difference that first one fails because of length already and second one fails at hex parsing stage?
Collaborator
Author
Yes, exactly that is the difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
Add a test case when there is a bin name with the desired prefix, but
which cannot be cast to a hexadecimal number.
Signed-off-by: Martin Vrachev mvrachev@vmware.com
Please verify and check that the pull request fulfills the following
requirements: