Skip to content

workflows: Use setup-python to setup python in coveralls-fin#2173

Merged
lukpueh merged 1 commit intotheupdateframework:developfrom
jku:fix-pip-cache-in-coveralls-fin
Nov 9, 2022
Merged

workflows: Use setup-python to setup python in coveralls-fin#2173
lukpueh merged 1 commit intotheupdateframework:developfrom
jku:fix-pip-cache-in-coveralls-fin

Conversation

@jku
Copy link
Copy Markdown
Member

@jku jku commented Nov 8, 2022

This makes the job just like all other jobs

Fixes #2172

Signed-off-by: Jussi Kukkonen jkukkonen@google.com

@jku jku marked this pull request as draft November 8, 2022 15:32
@jku jku force-pushed the fix-pip-cache-in-coveralls-fin branch from 37bd1a8 to 219a93d Compare November 8, 2022 15:38
@lukpueh
Copy link
Copy Markdown
Member

lukpueh commented Nov 8, 2022

Do you know why coveralls-fin fails now?

@jku
Copy link
Copy Markdown
Member Author

jku commented Nov 8, 2022

Do you know why coveralls-fin fails now?

in this branch? apparently setup-python absolutely wants a file to use as cache invalidation method, and we don't have any files... not sure why it requires that 🤷

This makes the job just like all other jobs

Fixes theupdateframework#2172

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku force-pushed the fix-pip-cache-in-coveralls-fin branch from 219a93d to a6c3b48 Compare November 8, 2022 16:54
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3421483909

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.189%

Totals Coverage Status
Change from base Build 3393687438: 0%
Covered Lines: 1346
Relevant Lines: 1362

💛 - Coveralls

@jku jku marked this pull request as ready for review November 8, 2022 17:01
@jku
Copy link
Copy Markdown
Member Author

jku commented Nov 8, 2022

that took a few tries: there's now a touch requirements.txt in there to create a file that setup-python can hash to create a cache lookup key... A bit dumb but should work for the purpose

@lukpueh lukpueh merged commit 7311808 into theupdateframework:develop Nov 9, 2022
@jku jku deleted the fix-pip-cache-in-coveralls-fin branch December 30, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coveralls-fin workflow job sometimes fails

3 participants