Fix pydocstyle D401: first line should be in imperative mood#2230
Merged
jku merged 1 commit intotheupdateframework:developfrom Dec 27, 2022
Merged
Fix pydocstyle D401: first line should be in imperative mood#2230jku merged 1 commit intotheupdateframework:developfrom
jku merged 1 commit intotheupdateframework:developfrom
Conversation
Signed-off-by: Fridolin Pokorny <fridolin.pokorny@datadoghq.com>
b8054c6 to
c4e1479
Compare
Pull Request Test Coverage Report for Build 3724758599Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Member
|
See #2231 (review) |
jku
approved these changes
Dec 27, 2022
Member
jku
left a comment
There was a problem hiding this comment.
I have no strong opinions on whether to have a linter for this but the fixes seem good and unlikely to be too annoying in git blame so I'm approving and merging these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
Make sure the codebase is more compliant with Python's docstring convention.