Skip to content

Fix pydocstyle D401: first line should be in imperative mood#2230

Merged
jku merged 1 commit intotheupdateframework:developfrom
fridex:pydocstyle-imperative-mood
Dec 27, 2022
Merged

Fix pydocstyle D401: first line should be in imperative mood#2230
jku merged 1 commit intotheupdateframework:developfrom
fridex:pydocstyle-imperative-mood

Conversation

@fridex
Copy link
Copy Markdown
Contributor

@fridex fridex commented Dec 18, 2022

Description of the changes being introduced by the pull request:

Make sure the codebase is more compliant with Python's docstring convention.

Signed-off-by: Fridolin Pokorny <fridolin.pokorny@datadoghq.com>
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 18, 2022

Pull Request Test Coverage Report for Build 3724758599

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 98.195%

Totals Coverage Status
Change from base Build 3711857675: 0.001%
Covered Lines: 1350
Relevant Lines: 1366

💛 - Coveralls

@lukpueh
Copy link
Copy Markdown
Member

lukpueh commented Dec 19, 2022

See #2231 (review)

Copy link
Copy Markdown
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinions on whether to have a linter for this but the fixes seem good and unlikely to be too annoying in git blame so I'm approving and merging these.

@jku jku merged commit ba9ea5b into theupdateframework:develop Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants