Expose default fetcher#2277
Merged
lukpueh merged 3 commits intotheupdateframework:developfrom Jan 26, 2023
Merged
Conversation
This is useful for those who want to use the default fetcher but modify some attributes The file itself could be moved to tuf/ngclient/ but this is not done yet as sigstore-python is using this internal module. Move can be done once sigstore-python 1.0 is no longer relevant. Fixes theupdateframework#2268 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
This only documents the configurable attributes and not the inherited methods. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Pull Request Test Coverage Report for Build 4013155749
💛 - Coveralls |
Member
Author
joshuagl
approved these changes
Jan 25, 2023
Member
joshuagl
left a comment
joshuagl
left a comment
There was a problem hiding this comment.
All looks good to me. I made a minor suggestion, but feel free to ignore.
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Closed
lukpueh
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for those who want to use the default fetcher but modify some attributes
The file itself could be moved to tuf/ngclient/ but this is not done yet as sigstore-python is using this internal module. Move can be done once sigstore-python 1.0 is no longer relevant.
Fixes #2268
Signed-off-by: Jussi Kukkonen jkukkonen@google.com
Please verify and check that the pull request fulfills the following
requirements: