Add TargetFile.get_prefixed_paths()#2338
Merged
lukpueh merged 4 commits intotheupdateframework:developfrom Mar 29, 2023
Merged
Conversation
Signed-off-by: Kamui <fin-kamui@pm.me>
Signed-off-by: Kamui <fin-kamui@pm.me>
Signed-off-by: Kamui <fin-kamui@pm.me>
* Use the same solution for producing the paths as we already do in ngclient * Fix linting issues * Modify the test results according to new code (I believe these are correct, although some cases are so edge cases that disagreement may exist. Most importantly I think the method should always return as many paths as there are hashes listed Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Pull Request Test Coverage Report for Build 4469986911
💛 - Coveralls |
lukpueh
approved these changes
Mar 29, 2023
Member
lukpueh
left a comment
lukpueh
left a comment
There was a problem hiding this comment.
I was surprised to see that we don't put any restrictions on target paths. Other than that, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2166.
This is the branch from #2180, with my improvements on top. It's a simple method but the edge cases are not obvious so it makes sense for python-tuf to handle this -- if applications do, then we end up with a many slightly different implementations.