Review and update Pull Request #238.#239
Merged
vladimir-v-diaz merged 4 commits intotheupdateframework:developfrom Jul 18, 2014
Merged
Review and update Pull Request #238.#239vladimir-v-diaz merged 4 commits intotheupdateframework:developfrom
vladimir-v-diaz merged 4 commits intotheupdateframework:developfrom
Conversation
A change of line or any other character outside the public key makes changes the keyid and breaks the behaviour of TUF. Remove everything before '-----BEGIN PUBLIC KEY-----' and after '-----END PUBLIC KEY-----'.
re.sub() with the 'flags' keyword argument caused type error in Python 2.6. Converted PEM validation to use index() to address issue above. Raise specific exception depending on missing header / footer. Check footer follows header.
Add test_formats_rsakey_from_pem() test case and test conditions for improperly formatted PEM. Add test condition to verify trailing whitespace is removed and matches the expected PEM format generated internally. Public PEMs generated externally (with the expected trailing newline) was not previously considered.
vladimir-v-diaz
added a commit
that referenced
this pull request
Jul 18, 2014
Review and update Pull Request #238.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internally. Public PEMs generated externally (with the expected trailing newline) was not previously considered.
Thanks @meskio for the pull request, and for supplying the scripts / PEM files to test.