Skip to content

fix(Scenarios/XForwardedFor): correct the trigger of the alert + add cache to skip double ip extraction#30

Merged
thib3113 merged 1 commit intomainfrom
fix-x-forwarded-for
Aug 20, 2023
Merged

fix(Scenarios/XForwardedFor): correct the trigger of the alert + add cache to skip double ip extraction#30
thib3113 merged 1 commit intomainfrom
fix-x-forwarded-for

Conversation

@thib3113
Copy link
Owner

correcting the way the alert is trigger + add cache to skip double ip extraction

 - correct the trigger of the alert
 - add cache to skip double ip extraction
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Merging #30 (a53cc14) into main (0700b0d) will increase coverage by 0.06%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   58.19%   58.25%   +0.06%     
==========================================
  Files          30       30              
  Lines         952      963      +11     
  Branches      194      195       +1     
==========================================
+ Hits          554      561       +7     
- Misses        350      354       +4     
  Partials       48       48              
Flag Coverage Δ
crowdsec-client 100.00% <ø> (ø)
crowdsec-client-scenarios 37.75% <61.53%> (+1.23%) ⬆️
crowdsec-http-middleware 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/scenarios/XForwardedFor/XForwardedForChecker.ts 78.12% <61.53%> (-1.88%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0700b0d...a53cc14. Read the comment docs.

@sonarqubecloud
Copy link

[crowdsec-client-scenarios] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

53.3% 53.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud
Copy link

[crowdsec-http-middleware] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[crowdsec-client] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thib3113 thib3113 merged commit dec0c82 into main Aug 20, 2023
@thib3113 thib3113 deleted the fix-x-forwarded-for branch August 20, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants