Fix bugs: custom chore solo mode, history rendering, torch overlap + docs rewrite#1
Merged
thillygooth merged 2 commits intoMay 28, 2026
Conversation
added 2 commits
May 28, 2026 16:19
Bug fixes: - Fix custom chores always defaulting to party mode (shared) instead of allowing solo (per-player) tracking. Custom chore form now includes ALL/1P mode selector. Also fix custom chores not receiving choreOverrides (toggle was saved but never applied). - Fix history tab rendering badge unlocks as monster kills with '+undefined gold'. Badge entries now show 'earned X 🏅' and loot entries show 'found X' with correct values. Added tile mappings for badge and loot history types. - Fix torches overlapping player cards on tablet-width screens (iPad). Hidden via media query below 1400px. Documentation: - Fix broken screenshot.png link in README (now screenshots_combined.png) - Add quick reference section to README (classes, midnight penalty, dungeon overview, reset week) - Add link to full game guide - Rewrite DOCS.md with comprehensive coverage: hero classes, midnight penalty mechanics, reset week behavior, dungeon guide with controls and strategy, combat mechanics, power-ups, badges, leveling formula, auto-reset schedule
CarelvanHeerden
force-pushed
the
fix/responsive-torches-overlap
branch
from
deee534 to
9a4256d
Compare
thillygooth
added a commit
that referenced
this pull request
May 28, 2026
Keep full guide from PR #1, add week start day info to Automatic Resets table. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fixes and documentation improvements based on real-world family testing on an iPad.
Bug Fixes
1. Torches overlap player cards on tablets (iPad)
The decorative torches (
position: fixedat 14px from edges) overlap player cards on screens narrower than ~1400px. Added a media query to hide them on tablet-width screens.2. Custom chores always shared (party mode) — no solo option
Custom chores had no
modefield in the creation form, so they always defaulted toparty(shared). When one player completed "Brush Teeth Morning", it was marked done for all players.Fixes:
App.jsxto applychoreOverridesto custom chores (previously only built-in chores received overrides, so the ALL/1P toggle was a no-op for custom chores)3. Badge unlocks render as "+undefined gold" in history
Badge entries (
type: "badge") and loot entries (type: "loot") were rendered by the catch-all "slew" formatter, producing entries like "Amy slew First Blood (+undefined gold)".Fix: Added proper rendering for badge and loot history types:
Also added tile mappings for badge (heart) and loot (chest) icons in history.
Documentation
README.md
screenshot.pngimage link →screenshots_combined.pngDOCS.md — Comprehensive rewrite
The existing DOCS.md was minimal. Rewrote with full coverage:
Testing
Tested against the codebase by reviewing all logic paths. Changes are CSS-only (torch hide), form state additions (custom chore mode), and render logic (history tab switch statement).