Skip to content

fix: only initialize session when used#2

Merged
reubenmiller merged 1 commit intomainfrom
fix-lazy-session-init
Aug 30, 2024
Merged

fix: only initialize session when used#2
reubenmiller merged 1 commit intomainfrom
fix-lazy-session-init

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Prevent class instantiation problems when the AWS config is not set by lazily creating the session when trying to access the AWS API

@reubenmiller reubenmiller force-pushed the fix-lazy-session-init branch from d74af89 to be3a7f9 Compare August 30, 2024 03:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 30, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
15 0 0 15 100 2.839891s

Passed Tests

Name ⏱️ Duration Suite
Get IoT Url 0.406 s Account
Get Account ID 0.330 s Account
Create certificate key pair 0.286 s Certificates
Create CSR using AWS CA 0.333 s Certificates
Upload self-signed certificate 0.349 s Certificates
Create a new Policy 0.153 s Policies
Deleting a non-existent Policy should not throw an error 0.071 s Policies
Deleting a non-existent Policy should throw an error 0.068 s Policies
Assert that a policy exists 0.150 s Policies
Fails if policy does not exist 0.067 s Policies
Create Thing with auto cleanup 0.142 s Thing
Delete Thing 0.211 s Thing
Delete non-existent thing 0.068 s Thing
Check if thing exists 0.067 s Thing
Throws an error if thing exists 0.139 s Thing

@reubenmiller reubenmiller force-pushed the fix-lazy-session-init branch from be3a7f9 to 05b3506 Compare August 30, 2024 03:47
@reubenmiller reubenmiller added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 61cc5f2 Aug 30, 2024
@reubenmiller reubenmiller deleted the fix-lazy-session-init branch August 30, 2024 03:51
reubenmiller added a commit that referenced this pull request Apr 21, 2026
Add explicit permissions blocks to lint, approve, and passed jobs to
restrict the scope of the GITHUB_TOKEN following the principle of least
privilege.

Fixes code scanning alerts #2, #3, #4 (actions/missing-workflow-permissions)
reubenmiller added a commit that referenced this pull request Apr 21, 2026
Update cryptography minimum version from 44.0.2 to 46.0.6 to address
two security vulnerabilities:

- CVE-2026-26007 (high): Vulnerable to a Subgroup Attack Due to Missing
  Subgroup Validation for SECT Curves (fixed in 46.0.5)
- CVE-2026-34073 (low): Incomplete DNS name constraint enforcement on
  peer names (fixed in 46.0.6)

Fixes Dependabot alerts #2 and #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant