Common config for consumers and producers#282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
#279
This PR introduces three new environment variables to provide more flexible and granular configuration for Kafka clients (producers and consumers). Previously, configuration options were limited or required individual property mapping. These new variables allow passing raw Kafka properties directly.
The new environment variables are:
TB_KAFKA_DEFAULT_PRODUCER_CONSUMER_CONFIGTB_KAFKA_DEFAULT_CONSUMER_CONFIGTB_KAFKA_DEFAULT_PRODUCER_CONFIGConfiguration Precedence & Order of Usage
The configuration is applied in a specific hierarchical order, where specific configurations override general ones.
TB_KAFKA_DEFAULT_PRODUCER_CONSUMER_CONFIGis applied. This is useful for shared properties (e.g.,bootstrap.servers,security.protocol, SASL config).TB_KAFKA_DEFAULT_PRODUCER_CONFIGorTB_KAFKA_DEFAULT_CONSUMER_CONFIGis applied.Logic:
TB_KAFKA_DEFAULT_PRODUCER_CONSUMER_CONFIG+TB_KAFKA_DEFAULT_PRODUCER_CONFIGTB_KAFKA_DEFAULT_PRODUCER_CONSUMER_CONFIG+TB_KAFKA_DEFAULT_CONSUMER_CONFIGNote: If a property exists in both the shared config and the specific config, the specific config value takes precedence.
Also, specific configurations, such as TB_KAFKA_MSG_ALL_ADDITIONAL_* and other topic-specific settings, take precedence over TB_KAFKA_DEFAULT_CONSUMER_CONFIG and TB_KAFKA_DEFAULT_PRODUCER_CONFIG.
General checklist
Front-End feature checklist
Back-End feature checklist