feat(topic-rules): Add copy and paste functionality#302
Merged
dmytro-landiak merged 2 commits intoApr 6, 2026
Conversation
deaflynx
reviewed
Apr 3, 2026
Contributor
deaflynx
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Nice refactoring of the duplicated chip-list logic.
One concern: Adding COMMA as a separator key will break regex quantifier patterns like sensor/.{1,3} — the comma would split it into two invalid chips (sensor/.{1 and 3}). MQTT auth rules support regex, so this is a realistic user input. Consider removing COMMA from the separator keys. SEMICOLON is fine to keep — it has no special meaning in regex and is not used in MQTT topics.
deaflynx
requested changes
Apr 3, 2026
Removal is to avoid regex patterns with a comma to break, such as 'sensor/.{1,3}'.
deaflynx
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
#301
Adds the ability to copy topic rules and paste topic rules. This change also extracts the chiplist logic to a separate component because it is now duplicated thrice.
Before
After
Screen.Recording.2026-04-02.at.12.38.03.mov
General checklist
I did not see another suitable branch other than main, due to the other branches being outdated.
Front-End feature checklist
Back-End feature checklist