fix(installation): clone k8s repos by full-version release branch#456
Merged
Conversation
thingsboard-ce-k8s / thingsboard-pe-k8s are branched per full version (release-4.3.1.2), not per minor release, so 'git clone -b release-4.3' failed on 12 cloud installation pages. Centralize the snippet in k8sCloneCmd() (src/util/install-commands.ts) and use it on all 16 k8s installation pages; keep CE_BRANCH for repos that do branch per minor release (thingsboard, rule-node-examples).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thingsboard-ce-k8s/thingsboard-pe-k8sare branched per full version (release-4.3.1.2), not per minor release —git clone -b release-4.3on 12 cloud installation pages (AWS/Azure/GCP × monolith/microservices, CE + PE) failed because that branch doesn't exist in those repos.k8sCloneCmd(repo, dir)insrc/util/install-commands.tsand switched all 16 k8s installation pages (incl. minikube/openshift) to it, so the repo URL, branch format, and--depth 1live in one place.CE_BRANCHstays for repos that do branch per minor release (thingsboard,rule-node-examples), with a comment pointing k8s usage to the helper.