Skip to content

Add possibility to create Assets, Dashboards, EntityViews, AssetProfile, DeviceProfile on edge#9087

Merged
ashvayka merged 3 commits intothingsboard:develop/3.5.2from
AndriiLandiak:feature/edge-entity-creation
Aug 16, 2023
Merged

Add possibility to create Assets, Dashboards, EntityViews, AssetProfile, DeviceProfile on edge#9087
ashvayka merged 3 commits intothingsboard:develop/3.5.2from
AndriiLandiak:feature/edge-entity-creation

Conversation

@AndriiLandiak
Copy link
Copy Markdown
Member

@AndriiLandiak AndriiLandiak commented Aug 16, 2023

Pull Request description

As for now, only Devices could be created on Edge and processed to Cloud.
Add the ability to create entities on Edge and send notifications to TB.
Supported Entities: Assets, Dashboards, EntityViews, AssetProfile, DeviceProfile

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.


@Override
public void onFailure(Throwable t) {
log.debug("Failed to send ENTITY_CREATED EVENT to rule engine [{}]", asset, t);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warn?

return handleUnsupportedMsgType(assetProfileUpdateMsg.getMsgType());
}
} catch (DataValidationException e) {
if (e.getMessage().contains("limit reached")) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have limits for number of asset profiles?


@Override
public void onFailure(Throwable t) {
log.debug("Failed to send ENTITY_CREATED EVENT to rule engine [{}]", assetProfile, t);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warn?

@volodymyr-babak
Copy link
Copy Markdown
Member

LGTM

@ashvayka ashvayka merged commit 140d19b into thingsboard:develop/3.5.2 Aug 16, 2023
@AndriiLandiak AndriiLandiak deleted the feature/edge-entity-creation branch August 17, 2023 06:38
@volodymyr-babak volodymyr-babak added the Edge Changes to Edge support label Sep 21, 2023
@volodymyr-babak volodymyr-babak added this to the 3.6 milestone Sep 21, 2023
@volodymyr-babak volodymyr-babak changed the title Feature/entity creation on Edge Add possibility to create Assets, Dashboards, EntityViews, AssetProfile, DeviceProfile on edge Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edge Changes to Edge support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants