Solved multiple bugs in module info dialog #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joente
reviewed
Jun 16, 2021
|
|
||
| onSetModuleConf(nodeId, name, configuration, tag, cb) { | ||
| const query = `set_module_conf('${name}', ${configuration ? `'${configuration}'` : 'nil'});`; | ||
| const query = `set_module_conf('${name}', ${configuration ? `${configuration}` : 'nil'});`; |
Member
There was a problem hiding this comment.
It would be better to use query arguments instead of "building' the query, thus:
query = set_module_conf(name, configuration);
and as arguments:
{
"name": name,
"configuration: configuration
}
This way, it is also fine if configuration is nil, since that will be correctly packed.
Contributor
Author
There was a problem hiding this comment.
This will be changed in a later release (~v0.4.4).
joente
requested changes
Jun 16, 2021
Member
joente
left a comment
joente
left a comment
There was a problem hiding this comment.
Instead of query building, it would be an improvement to use query arguments instead.
joente
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #128 .