Raise minimum IDE to 2025.3 and fix PSI read assertion in 2026.1.1#96
Merged
Merged
Conversation
RubyMine 2026.1.1 throws "Read access is allowed from inside read-action only" when a row is selected in the routes table, because SimpleRoute lazily reads RailsAction.psiClass / psiMethod from getQualifiedActionTitle / getActionIcon / canNavigate / methodExists, all of which are invoked from the EDT (MainContent, ActionCellRenderer, RoutesTable double-click, RoutesTableFilter) outside of a read action. Capture the display-side values at init time inside the same ReadAction.run block as railsAction.update(), and have the getters return the cached snapshot. Navigation keeps using the existing ReadAction.nonBlocking re-resolution path so the jump target is still based on the latest PSI. Extract icon dispatch into a pure resolveActionIcon() helper so each branch (NodeRouteAction / NodeController / Unknown) can be unit-tested without the Ruby plugin services that are otherwise required to instantiate real RClass / RMethod under BasePlatformTestCase. Add SimpleRouteSnapshotTest covering: snapshot immutability, all three icon dispatch branches, default state with no Rails app, dynamic ":controller" routes, and the nested controller fallback (admin/users -> Admin::UsersController). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR covers the RubyMine 2025.3+ support baseline and the RubyMine 2026.1.1 PSI read-access fix.
Supporting the affected IDE line requires updating the Gradle/Kotlin/IntelliJ Platform toolchain and raising the minimum IDE build to
253(RubyMine 2025.3). With that baseline in place, RubyMine 2026.1.1 exposes a previously latent issue where route table UI rendering reads Ruby PSI from EDT-side getters.Summary
253(RubyMine 2025.3).SimpleRoutedisplay values during route construction so UI rendering, filtering, and selection handling no longer dereference Ruby PSI outside a read action.SimpleRoute.navigate()unchanged so navigation still re-resolves against the latest PSI viaReadAction.nonBlocking.Changes
since-build.testBundledModule("com.intellij.modules.json")because the Ruby plugin registers JSON file-type extensions during test initialization.SimpleRoute.ktwhile preserving the existingBaseRoutegetter API.SimpleRouteSnapshotTestfor snapshot invariants, fallback titles, dynamic routes, unresolved routes, and action icon dispatch.Notes
Rails Routesrun. This matches the existing routes-list behavior.BasePlatformTestCase, where Ruby plugin service setup is heavy.Testing
./gradlew check./gradlew test --tests '*SimpleRouteSnapshotTest*'