feature/1: Changing getter function to be called at lookup time inste…#2
Merged
ChrisSandison merged 10 commits intomainfrom May 29, 2023
Merged
feature/1: Changing getter function to be called at lookup time inste…#2ChrisSandison merged 10 commits intomainfrom
ChrisSandison merged 10 commits intomainfrom
Conversation
…ad of defined as part of the cache
added 9 commits
May 26, 2023 09:48
kbirk
approved these changes
May 29, 2023
kbirk
reviewed
May 29, 2023
| return value, false | ||
| } | ||
|
|
||
| func (c *partitionedCache[K, V]) Put(key K, value *V) { |
There was a problem hiding this comment.
I didn't originally add Put because you can't use it without introducing a race condition between it and Get. The Get and Put operations have to be atomic and behave similar to a compare and swap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ad of defined as part of the cache.
For instance, when the getter function takes something like the reporter then this can't be used
Fixes #1