Fix circular dependency issues. Fix instances being "filled" multiple times#3
Merged
ChrisSandison merged 1 commit intomainfrom Mar 9, 2024
Merged
Fix circular dependency issues. Fix instances being "filled" multiple times#3ChrisSandison merged 1 commit intomainfrom
ChrisSandison merged 1 commit intomainfrom
Conversation
ChrisSandison
approved these changes
Mar 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Of course I introduce the recursive filling without realizing that:
A) It was re-filling previously instantiated singleton types
B) It introduces the possibility of filling infinite cycles, deadlocking on singletons and stack overflowing on instances.
This PR fixes both of those.
A) Singleton types will only ever be "filled" once.
B) Injection now gracefully handles cyclical objects, in the case of instances, the values are cached each that injection so resolve them.
The only outward change is that we can no longer create provider that returns structs by value. There is no benefit in doing so, since that is what the
Instanceregistration is for anyway.