Skip to content

Fix automated release publishing#376

Merged
thinkst-az merged 2 commits intomasterfrom
fix_publish
Oct 14, 2024
Merged

Fix automated release publishing#376
thinkst-az merged 2 commits intomasterfrom
fix_publish

Conversation

@thinkst-az
Copy link
Contributor

Proposed changes

The automated release package creation on PyPi did not trigger due to incorrect release event specified. This change ensures it is published.

Includes a fix to typo in documentation.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Linked to the relevant github issue or github discussion

Copy link

@roberto-aldera roberto-aldera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✊

@thinkst-az thinkst-az merged commit 04357d1 into master Oct 14, 2024
@thinkst-az thinkst-az deleted the fix_publish branch October 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants