Skip to content

Migrate ntp test to pytest#475

Merged
thinkst-pieter merged 1 commit into
masterfrom
migrate_to_pytest_ntp
May 15, 2026
Merged

Migrate ntp test to pytest#475
thinkst-pieter merged 1 commit into
masterfrom
migrate_to_pytest_ntp

Conversation

@thinkst-pieter
Copy link
Copy Markdown
Contributor

@thinkst-pieter thinkst-pieter commented May 15, 2026

Proposed changes

Migrate the testing to pytest from the python unit test into a dedicated test file for each opencanary module in preparation of adding more testing.

This PR handles the ntp tests

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Linked to the relevant github issue or github discussion

@thinkst-pieter thinkst-pieter merged commit f6cd782 into master May 15, 2026
21 checks passed
@thinkst-pieter thinkst-pieter deleted the migrate_to_pytest_ntp branch May 15, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants