Update to Electron v9#76
Merged
hidakatsuya merged 4 commits intomasterfrom Jun 17, 2020
Merged
Conversation
Merged
Member
Author
Member
Author
I will fix this issue separately. |
hidakatsuya
commented
Jun 16, 2020
| icon: path.join(__dirname, 'assets/images/app-icon.png') | ||
| icon: path.join(__dirname, 'assets/images/app-icon.png'), | ||
| webPreferences: { | ||
| nodeIntegration: true, |
Member
Author
There was a problem hiding this comment.
This option should not be enabled, so I fix it to false.
https://www.electronjs.org/docs/tutorial/security#2-do-not-enable-nodejs-integration-for-remote-content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates Electron and other dependencies. And it will fix #75 .
Review
You can review on the package built in the #77 job.
Known Issue
Splash on startup is not displayed. -> It wil be fixed #78