Skip to content

allow any string to be set to the title of the PDF document metadata #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hidakatsuya merged 1 commit into from
Sep 6, 2023
Merged

allow any string to be set to the title of the PDF document metadata #125

hidakatsuya merged 1 commit into from
Sep 6, 2023

Conversation

@hidakatsuya
Copy link
Member

@hidakatsuya hidakatsuya commented Sep 6, 2023 •
edited
Loading

This pull request implements the functionality proposed below the discussion
https://github.com/orgs/thinreports/discussions/37

Usage

# foo.tlf has the title "Foo Title".
report = Thinreports::Report.new layout: "foo.tlf"
report.start_new_page

report.generate title: "Custom Title"

The metadata title of the PDF document generated above should be set to "Custom Title".

@hidakatsuya hidakatsuya added the enhancement New feature or request label Sep 6, 2023
@hidakatsuya hidakatsuya self-assigned this Sep 6, 2023
@hidakatsuya hidakatsuya changed the title allow any string to be set to the title attribute of the PDF document metadata allow any string to be set to the title of the PDF document metadata Sep 6, 2023
@hidakatsuya hidakatsuya merged commit 5a00142 into main Sep 6, 2023
@hidakatsuya hidakatsuya deleted the make-editable-meta-data branch September 6, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hidakatsuya hidakatsuya

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hidakatsuya