Update the src/test/token/TokenERC20.t.sol #667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Tests for Signature Validation and Gas Efficiency
I added the testFailMintWithInvalidSignature to check if minting with an invalid signature fails as expected.
Introduced testGasMinting to log gas usage during the minting process for efficiency tracking.
Aligned MintRequest structure in tests with existing contract setup.
Reason:
Strengthens security by ensuring only valid signatures can mint tokens.
Provides insights into gas costs for minting operations.
Impact:
No breaking changes; purely additive tests for better coverage.