reduce max_inflight to 20

[joaquim-verges]

Summary by CodeRabbit

• Chores
  • Introduced cleanup tooling for failed pending transactions
  • Adjusted concurrent transaction processing limits

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces a new TypeScript script for cleaning up failed pending transactions from Redis, processing them in configurable batches with dry-run support. Also reduces the max_inflight limit for EOA executor job handler from 100 to 20.

Changes

Cohort / File(s)	Summary
New Redis cleanup script scripts/cleanup-failed-pending-txs.ts	New script that connects to Redis, retrieves pending transactions from a sorted set, checks their statuses in batch operations, collects failed transactions, and deletes them in configurable batches with DRY RUN mode support. Includes startup diagnostics logging and comprehensive error handling.
Queue manager executor tuning server/src/queue/manager.rs	Reduced max_inflight from 100 to 20 in EoaExecutorJobHandler initialization within QueueManager::new.

Sequence Diagram

sequenceDiagram
    participant Script
    participant Redis
    participant Pipeline
    
    Script->>Redis: Connect & validate REDIS_URL
    Script->>Redis: Get total pending txs (zcard)
    
    loop For each batch
        Script->>Redis: Fetch tx IDs (zrange with offset)
        Script->>Pipeline: Queue hget for each tx status
        Pipeline->>Redis: Execute pipeline
        Script->>Script: Aggregate statuses & collect failed txs
    end
    
    loop Delete batches (if not DRY RUN)
        Script->>Redis: zrem failed tx IDs
    end
    
    Script->>Script: Log statistics & results
    Script->>Redis: Close connection

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Redis connection handling and cleanup: Verify proper error handling and finally block ensures connection closure even on failure
• Batch processing logic: Confirm offset-based pagination with zrange correctly processes all pending transactions without duplication or gaps
• Status aggregation and failed transaction collection: Validate correctness of status filtering and that failed transaction identification matches intended criteria
• DRY RUN vs. actual deletion: Ensure conditional logic between simulated logging and actual zrem operations is correct
• Pipeline operations: Review error handling for failed pipeline executions and partial failures

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch Add_script_to_clean_up_failed_pending_transactions_and_reduce_max_inflight

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c4cbaa1 and fec433e.

📒 Files selected for processing (2)

• scripts/cleanup-failed-pending-txs.ts (1 hunks)
• server/src/queue/manager.rs (1 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[joaquim-verges]

• reduce max_inflight to 20 #84 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.