Skip to content

init fixing cli #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

init fixing cli #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions packages/cli/src/common/processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,9 @@ export async function processProject(
const metadataURIs = await Promise.all(
selectedContracts.map(async (c) => {
logger.debug(`Uploading ${c.name}...`);
const hash = await storage.upload(c.metadata, {
return await storage.upload(c.metadata, {
uploadWithoutDirectory: true,
});
return `ipfs://${hash}`;
}),
);

Expand Down Expand Up @@ -194,18 +193,9 @@ export async function processProject(
}

export function getUrl(hashes: string[], command: string) {
let url;
if (hashes.length === 1) {
url = new URL(
THIRDWEB_URL +
`/contracts/${command}/` +
encodeURIComponent(hashes[0].replace("ipfs://", "")),
);
} else {
url = new URL(THIRDWEB_URL + "/contracts/" + command);
for (let hash of hashes) {
url.searchParams.append("ipfs", hash.replace("ipfs://", ""));
}
const url = new URL(THIRDWEB_URL + "/contracts/" + command);
for (let hash of hashes) {
url.searchParams.append("ipfs", hash.replace("ipfs://", ""));
Copy link
Member

@joaquim-verges joaquim-verges Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the dashboard handle single contract deploy/releases if i pass just one ipfs query param?

}
return url;
}