Skip to content

[SDK] Allow forcing direct deploys to deploy implementations from release flow #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2022
+11 −2
Merged

[SDK] Allow forcing direct deploys to deploy implementations from release flow #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6e7e8d
[SDK] Allow forcing direct deploys to deploy implementations from rel…
joaquim-verges Sep 20, 2022
81596f6
add changeset
joaquim-verges Sep 20, 2022
9529733
Merge branch 'main' into joaquim/allow_force_direct_deploys
joaquim-verges Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/weak-meals-lay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/sdk": patch
---

Allow forcing direct deploys to deploy implementations from release flow
8 changes: 6 additions & 2 deletions packages/sdk/src/core/classes/contract-deployer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,10 +502,14 @@ export class ContractDeployer extends RPCConnectionHandler {
* @internal
* @param publishMetadataUri
* @param constructorParamValues
* @param options
*/
public async deployContractFromUri(
publishMetadataUri: string,
constructorParamValues: any[],
options?: {
forceDirectDeploy?: boolean;
},
) {
const signer = this.getSigner();
invariant(signer, "A signer is required");
Expand All @@ -527,8 +531,8 @@ export class ContractDeployer extends RPCConnectionHandler {
} catch (e) {
// not a factory deployment, ignore
}

if (isDeployableViaFactory && factoryDeploymentData) {
const forceDirectDeploy = options?.forceDirectDeploy || false;
if (isDeployableViaFactory && factoryDeploymentData && !forceDirectDeploy) {
const chainId = (await this.getProvider().getNetwork()).chainId;
invariant(
factoryDeploymentData.factoryAddresses,
Expand Down