Skip to content

[SDK] Catch gas estimate errors in gasless tx #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

[SDK] Catch gas estimate errors in gasless tx #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa35267
catch gas estimate errors in gasless tx
joaquim-verges Sep 20, 2022
f7b82a8
add changeset
joaquim-verges Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-news-compete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/sdk": patch
---

Catch gas estimate errors in gasless tx
15 changes: 10 additions & 5 deletions packages/sdk/src/core/classes/contract-wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,14 +434,19 @@ export class ContractWrapper<
args as any,
);

const gasEstimate = await (this.writeContract.estimateGas as any)[fn](
...args,
);
let gas = gasEstimate.mul(2);
let gas = BigNumber.from(0);
try {
const gasEstimate = await (this.readContract.estimateGas as any)[fn](
...args,
);
gas = gasEstimate.mul(2);
} catch (e) {
// ignore
}

// in some cases WalletConnect doesn't properly gives an estimate for how much gas it would actually use.
// as a fix, we're setting it to a high arbitrary number (500k) as the gas limit that should cover for most function calls.
if (gasEstimate.lt(50000)) {
if (gas.lt(100000)) {
gas = BigNumber.from(500000);
}

Expand Down