[SmartWallet] implement multidimensional nonces for smart wallets #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d1d226d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
IDubuque
pushed a commit
that referenced
this pull request
Oct 31, 2023
IDubuque
pushed a commit
that referenced
this pull request
Nov 9, 2023
[RN] Update weights (#1817) [RN] i18n more strings and fix fontFamily (#1818) [RN] i18n strings (#1819) [RN] Allow custom fontFamily (#1820) [SmartWallet] implement multidimensional nonces for smart wallets (#1821) [wallets, react] expose `onAuthSuccess` callback in `paperWallet` (#1815) [SDK] Perf improvement for erc-1155-signature-mintable (#1824) [wallets, react] Add OKX wallet (#1826) Version Packages (#1793) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [SDK] Improve contract-roles methods (#1798) Spicy chain gas override (#1805) Use BigInt function instead of bigint primitive numbers (#1830) [RN] Allows for custom auth with embeddedWallet (#1806) [RN] Update changelog (#1833) [SDK] Perf improvements for erc-20 methods (#1814) Signed-off-by: Kien Ngo <kenseverus@gmail.com> [SDK] Add ERC6551 Interface (#1324) Co-authored-by: ikethirdweb <jorge@thirdweb.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Patch: missing data arg in isSmartWalletDeployed (#1840) [RN] Update naming for embeddedWallet jwt flow (#1841) [SDK] Remove barrel files in `@r\packages\sdk\src\evm` (#1827) Signed-off-by: Kien Ngo <kenseverus@gmail.com> [RN] Migrate embedded wallet to new api (#1844) [SDK] Fix double trailing slash when downloading merkle data (#1850) chore(chains): sync chains (#1843) Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com> [Wallet] Fix getSmartWalletAddress util function (#1851) [wallets] - Fix chains package not tree-shaken because of SmartWallet (#1853) [SDK/Wallets] Override crypto-js to use latest version to fix vulnera… (#1854) Fix typo in comments (#1839) Signed-off-by: vuittont60 <81072379+vuittont60@users.noreply.github.com> feat: Update minimum required Node version to 18.17.0 (#1855) [SmartWallet] Expose new estimation functions for smart wallet transactions (#1856) feat: Update minimum required Node.js version to >=18 (#1858) Revert "[SDK/Wallets] Override crypto-js to use latest version to fix vulnera…" (#1859) Version Packages (#1828) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> chore(chains): sync chains (#1865) [SmartWallet] expose data in smart wallet utils (#1867) Version Packages (#1866) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [WALLET + REACT] Add Cometh Connect (#1749) Signed-off-by: Manan Tank <manantankm@gmail.com> Co-authored-by: Manan Tank <manantankm@gmail.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Revert "[WALLET + REACT] Add Cometh Connect" (#1879) [SDK] Lazy load JSON files (#1862) Signed-off-by: Kien Ngo <kenseverus@gmail.com> [RN] Adds Japanese and Spanish support (#1878)
|
The multidimensional nonce breaks compatibility reaching RPC endpoints using custom Paymaster/Bundlers, such as the Particle Bundler. NOW: FIX: Let me know if it's all clear. |
|
@3Vis3 interesting, what error do you get from the particle bundler? Multidimensional nonces are an important feature so that userOps can be send in quick succession without waiting for the bundler to submit the op onchain. I get your fix but wonder if instead we should allow to control the behavior a bit more explicitly. Feel free to put up a PR and we can discuss implementations there |
jnsdls
pushed a commit
that referenced
this pull request
Jun 19, 2024
Bumps [@types/papaparse](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/papaparse) from 5.3.9 to 5.3.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/papaparse) --- updated-dependencies: - dependency-name: "@types/papaparse" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
You can now chain send transactions without waiting for confirmations on smart wallets
Changes made
How to test