Skip to content

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 21, 2023

Problem solved

continue the work for #1648

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2023

🦋 Changeset detected

Latest commit: 8b4f629

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/sdk/src/evm/common/index.ts 100.00% <100.00%> (ø)
packages/sdk/src/evm/common/legacy.ts 100.00% <100.00%> (ø)
packages/sdk/src/evm/common/parseSnapshotInputs.ts 100.00% <100.00%> (ø)
...sdk/src/evm/common/plugin/getCompositePluginABI.ts 75.00% <100.00%> (ø)
packages/sdk/src/evm/common/sign.ts 42.85% <ø> (ø)
.../contracts/prebuilt-implementations/marketplace.ts 73.75% <100.00%> (ø)
...ntracts/prebuilt-implementations/nft-collection.ts 89.85% <ø> (ø)
...src/evm/contracts/prebuilt-implementations/pack.ts 67.66% <100.00%> (-0.39%) ⬇️
...rc/evm/contracts/prebuilt-implementations/split.ts 86.17% <100.00%> (-0.70%) ⬇️
...sdk/src/evm/core/classes/erc-721-batch-mintable.ts 92.59% <ø> (ø)
... and 8 more

📢 Thoughts on this report? Let us know!.

@kien-ngo kien-ngo marked this pull request as ready for review October 21, 2023 22:28
@kien-ngo kien-ngo requested a review from a team October 21, 2023 22:28
@kien-ngo kien-ngo added this pull request to the merge queue Oct 21, 2023
Merged via the queue into main with commit d8d48a9 Oct 21, 2023
@kien-ngo kien-ngo deleted the kien/various-perf-0 branch October 21, 2023 22:34
@github-actions github-actions bot mentioned this pull request Oct 21, 2023
IDubuque pushed a commit that referenced this pull request Nov 9, 2023
[RN] Update weights (#1817)

[RN] i18n more strings and fix fontFamily (#1818)

[RN] i18n strings (#1819)

[RN] Allow custom fontFamily (#1820)

[SmartWallet] implement multidimensional nonces for smart wallets (#1821)

[wallets, react] expose `onAuthSuccess` callback in `paperWallet` (#1815)

[SDK] Perf improvement for erc-1155-signature-mintable (#1824)

[wallets, react] Add OKX wallet (#1826)

Version Packages (#1793)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[SDK] Improve contract-roles methods (#1798)

Spicy chain gas override (#1805)

Use BigInt function instead of bigint primitive numbers (#1830)

[RN] Allows for custom auth with embeddedWallet (#1806)

[RN] Update changelog (#1833)

[SDK] Perf improvements for erc-20 methods (#1814)

Signed-off-by: Kien Ngo <kenseverus@gmail.com>

[SDK] Add ERC6551 Interface (#1324)

Co-authored-by: ikethirdweb <jorge@thirdweb.com>
Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>

Patch: missing data arg in isSmartWalletDeployed (#1840)

[RN] Update naming for embeddedWallet jwt flow (#1841)

[SDK] Remove barrel files in `@r\packages\sdk\src\evm` (#1827)

Signed-off-by: Kien Ngo <kenseverus@gmail.com>

[RN] Migrate embedded wallet to new api (#1844)

[SDK] Fix double trailing slash when downloading merkle data (#1850)

chore(chains): sync chains (#1843)

Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com>

[Wallet] Fix getSmartWalletAddress util function (#1851)

[wallets] - Fix chains package not tree-shaken because of SmartWallet  (#1853)

[SDK/Wallets] Override crypto-js to use latest version to fix vulnera… (#1854)

Fix typo in comments (#1839)

Signed-off-by: vuittont60 <81072379+vuittont60@users.noreply.github.com>

feat: Update minimum required Node version to 18.17.0 (#1855)

[SmartWallet] Expose new estimation functions for smart wallet transactions (#1856)

feat: Update minimum required Node.js version to >=18 (#1858)

Revert "[SDK/Wallets] Override crypto-js to use latest version to fix vulnera…" (#1859)

Version Packages (#1828)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore(chains): sync chains (#1865)

[SmartWallet] expose data in smart wallet utils (#1867)

Version Packages (#1866)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[WALLET + REACT] Add Cometh Connect (#1749)

Signed-off-by: Manan Tank <manantankm@gmail.com>
Co-authored-by: Manan Tank <manantankm@gmail.com>
Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>

Revert "[WALLET + REACT] Add Cometh Connect" (#1879)

[SDK] Lazy load JSON files (#1862)

Signed-off-by: Kien Ngo <kenseverus@gmail.com>

[RN] Adds Japanese and Spanish support (#1878)
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.28.1 to 2.29.0.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.28.1...v2.29.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant