[WALLET + REACT] Add Cometh Connect #1749
Conversation
🦋 Changeset detectedLatest commit: d8f7594 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 74 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
@yoanslvy Thanks for PR, We are excited to get this merged! I will test this shortly Don't worry about the failing tests - those are not related to your code change |
|
Hey @yoanslvy - I can't get an apiKey for testing :( 
|
|
Hello @MananTank - Thanks we are also eager to get this merged ! At the moment we are whitelisting emails to provide apiKeys for users. |
|
@yoanslvy Awesome, Can you whitelist the below emails: |
|
Hello @MananTank , I just added you guys to the whitelist, you can go to https://app.cometh.io to access you dashboard and apiKey ! |
|
By the way, how can we add a Reference for Cometh Connect in your doc? I saw that your provide wallet reference here: https://portal.thirdweb.com/wallet/metamask |
|
@yoanslvy - You can create a PR in thirdweb docs to add docs for cometh connect. I tested it out and added a connection UI in Modal. I was only able to get the Gnosis chain working. I was not able to connect to Mumbai ( even though the apiKey was for Mumbai ). I get "This network is not supported" error. Is this expected? |
|
Hello @MananTank, Thanks for the modal ! Perfect, I'll also add a PR to the thirdweb docs then. Regarding your issue, did you fetch the latest version of the PR before doing your test ? It should work on all of the supported networks |
|
@yoanslvy Hey, while trying to connect to Mumbai I am now getting below error: 
So, I tried adding 
|
|
/release-pr |
|
/release-pr |
|
Update: I am able to connect the wallet. I don't see any issue with merging the PR. We will merge this soon 🎉 |
Signed-off-by: Manan Tank <manantankm@gmail.com>
Signed-off-by: Manan Tank <manantankm@gmail.com> Co-authored-by: Manan Tank <manantankm@gmail.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>
Signed-off-by: Manan Tank <manantankm@gmail.com> Co-authored-by: Manan Tank <manantankm@gmail.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>
[RN] Update weights (#1817) [RN] i18n more strings and fix fontFamily (#1818) [RN] i18n strings (#1819) [RN] Allow custom fontFamily (#1820) [SmartWallet] implement multidimensional nonces for smart wallets (#1821) [wallets, react] expose `onAuthSuccess` callback in `paperWallet` (#1815) [SDK] Perf improvement for erc-1155-signature-mintable (#1824) [wallets, react] Add OKX wallet (#1826) Version Packages (#1793) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [SDK] Improve contract-roles methods (#1798) Spicy chain gas override (#1805) Use BigInt function instead of bigint primitive numbers (#1830) [RN] Allows for custom auth with embeddedWallet (#1806) [RN] Update changelog (#1833) [SDK] Perf improvements for erc-20 methods (#1814) Signed-off-by: Kien Ngo <kenseverus@gmail.com> [SDK] Add ERC6551 Interface (#1324) Co-authored-by: ikethirdweb <jorge@thirdweb.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Patch: missing data arg in isSmartWalletDeployed (#1840) [RN] Update naming for embeddedWallet jwt flow (#1841) [SDK] Remove barrel files in `@r\packages\sdk\src\evm` (#1827) Signed-off-by: Kien Ngo <kenseverus@gmail.com> [RN] Migrate embedded wallet to new api (#1844) [SDK] Fix double trailing slash when downloading merkle data (#1850) chore(chains): sync chains (#1843) Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com> [Wallet] Fix getSmartWalletAddress util function (#1851) [wallets] - Fix chains package not tree-shaken because of SmartWallet (#1853) [SDK/Wallets] Override crypto-js to use latest version to fix vulnera… (#1854) Fix typo in comments (#1839) Signed-off-by: vuittont60 <81072379+vuittont60@users.noreply.github.com> feat: Update minimum required Node version to 18.17.0 (#1855) [SmartWallet] Expose new estimation functions for smart wallet transactions (#1856) feat: Update minimum required Node.js version to >=18 (#1858) Revert "[SDK/Wallets] Override crypto-js to use latest version to fix vulnera…" (#1859) Version Packages (#1828) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> chore(chains): sync chains (#1865) [SmartWallet] expose data in smart wallet utils (#1867) Version Packages (#1866) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [WALLET + REACT] Add Cometh Connect (#1749) Signed-off-by: Manan Tank <manantankm@gmail.com> Co-authored-by: Manan Tank <manantankm@gmail.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Revert "[WALLET + REACT] Add Cometh Connect" (#1879) [SDK] Lazy load JSON files (#1862) Signed-off-by: Kien Ngo <kenseverus@gmail.com> [RN] Adds Japanese and Spanish support (#1878)
3 participants
Hello guys, We are happy to incorporate Cometh Connect to thirdweb !
Cometh Connect is a smart wallet based on Gnosis Safe contracts that provides biometric signatures (passwordless, non custodial), gasless transactions, account recovery, etc.
We understand the significance of this feature to our users, and we have committed ourselves to its implementation to enhance the usability of thirdweb and Cometh Connect.
If you want to go deeper:
Cometh Connect Docs: https://docs.cometh.io/connect/cometh-connect/what-is-connect