Skip to content

Conversation

iketw
Copy link
Contributor

@iketw iketw commented Oct 30, 2023

Reverts #1749

Found a few issues with the build:

../../../node_modules/.pnpm/@cometh+connect-sdk@1.2.0_@babel+core@7.22.9_react-is@18.2.0/node_modules/@cometh/connect-sdk/dist/wallet/connectors/ConnectOnboardConnector.js
  Module not found: ESM packages (@web3-onboard/common) need to be imported. Use 'import' to reference the package instead. https://nextjs.org/docs/messages/import-esm-externals

and:

Unable to resolve module @simplewebauthn/server/helpers from /Users/dalmendraytw/dev/thirdweb/mobile/node_modules/@cometh/connect-sdk/dist/services/webAuthnService.js: @simplewebauthn/server/helpers could not be found within the project or in these directories:
  node_modules/@cometh/connect-sdk/node_modules
  node_modules
  ../../node_modules
  36 | };
  37 | Object.defineProperty(exports, "__esModule", { value: true });
> 38 | const helpers_1 = require("@simplewebauthn/server/helpers");

@iketw iketw requested a review from a team as a code owner October 30, 2023 23:59
@iketw iketw requested a review from a team October 30, 2023 23:59
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

⚠️ No Changeset found

Latest commit: 58a07fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iketw iketw enabled auto-merge October 30, 2023 23:59
@iketw iketw added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit b49efc2 Oct 31, 2023
@iketw iketw deleted the revert-1749-feat/add-cometh-connect branch October 31, 2023 00:13
IDubuque pushed a commit that referenced this pull request Nov 9, 2023
[RN] Update weights (#1817)

[RN] i18n more strings and fix fontFamily (#1818)

[RN] i18n strings (#1819)

[RN] Allow custom fontFamily (#1820)

[SmartWallet] implement multidimensional nonces for smart wallets (#1821)

[wallets, react] expose `onAuthSuccess` callback in `paperWallet` (#1815)

[SDK] Perf improvement for erc-1155-signature-mintable (#1824)

[wallets, react] Add OKX wallet (#1826)

Version Packages (#1793)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[SDK] Improve contract-roles methods (#1798)

Spicy chain gas override (#1805)

Use BigInt function instead of bigint primitive numbers (#1830)

[RN] Allows for custom auth with embeddedWallet (#1806)

[RN] Update changelog (#1833)

[SDK] Perf improvements for erc-20 methods (#1814)

Signed-off-by: Kien Ngo <kenseverus@gmail.com>

[SDK] Add ERC6551 Interface (#1324)

Co-authored-by: ikethirdweb <jorge@thirdweb.com>
Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>

Patch: missing data arg in isSmartWalletDeployed (#1840)

[RN] Update naming for embeddedWallet jwt flow (#1841)

[SDK] Remove barrel files in `@r\packages\sdk\src\evm` (#1827)

Signed-off-by: Kien Ngo <kenseverus@gmail.com>

[RN] Migrate embedded wallet to new api (#1844)

[SDK] Fix double trailing slash when downloading merkle data (#1850)

chore(chains): sync chains (#1843)

Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com>

[Wallet] Fix getSmartWalletAddress util function (#1851)

[wallets] - Fix chains package not tree-shaken because of SmartWallet  (#1853)

[SDK/Wallets] Override crypto-js to use latest version to fix vulnera… (#1854)

Fix typo in comments (#1839)

Signed-off-by: vuittont60 <81072379+vuittont60@users.noreply.github.com>

feat: Update minimum required Node version to 18.17.0 (#1855)

[SmartWallet] Expose new estimation functions for smart wallet transactions (#1856)

feat: Update minimum required Node.js version to >=18 (#1858)

Revert "[SDK/Wallets] Override crypto-js to use latest version to fix vulnera…" (#1859)

Version Packages (#1828)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore(chains): sync chains (#1865)

[SmartWallet] expose data in smart wallet utils (#1867)

Version Packages (#1866)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[WALLET + REACT] Add Cometh Connect (#1749)

Signed-off-by: Manan Tank <manantankm@gmail.com>
Co-authored-by: Manan Tank <manantankm@gmail.com>
Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>

Revert "[WALLET + REACT] Add Cometh Connect" (#1879)

[SDK] Lazy load JSON files (#1862)

Signed-off-by: Kien Ngo <kenseverus@gmail.com>

[RN] Adds Japanese and Spanish support (#1878)
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* Localization Test

* update

* update

* update

* update packages

* update

---------

Signed-off-by: Manan Tank <manantankm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant