Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Sep 22, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: 4e4be0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@thirdweb-dev/storage Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/solana Patch
@thirdweb-dev/auth Patch
thirdweb Patch
@thirdweb-dev/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jnsdls jnsdls requested a review from adam-maj September 22, 2022 08:51
@jnsdls jnsdls changed the title [Storage] - allow uploading the same file multiple times in uploadBat… [Storage] - allow uploading the same file multiple times in uploadBatch if it is *the same file* Sep 22, 2022
@jnsdls
Copy link
Member Author

jnsdls commented Sep 22, 2022

@adam-maj just tagged so u see it

@jnsdls jnsdls enabled auto-merge (squash) September 22, 2022 09:02
@nachoiacovino
Copy link
Contributor

does this make it so it works the same as before or we're making it so we're only uploading it once and using the same URI for both?

@jnsdls
Copy link
Member Author

jnsdls commented Sep 22, 2022

does this make it so it works the same as before or we're making it so we're only uploading it once and using the same URI for both?

the second one of those ;)

@nachoiacovino
Copy link
Contributor

does this make it so it works the same as before or we're making it so we're only uploading it once and using the same URI for both?

the second one of those ;)

nice

@jnsdls jnsdls merged commit 3580182 into main Sep 22, 2022
@jnsdls jnsdls deleted the jonas/ftd-968 branch September 22, 2022 09:33
@github-actions github-actions bot mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants