Skip to content

Conversation

@adam-maj
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: 0c61015

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@thirdweb-dev/storage Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/solana Patch
@thirdweb-dev/auth Patch
thirdweb Patch
@thirdweb-dev/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR


if (files.length) {
// Upload all files that came from the object
const uris = await this.uploader.uploadBatch(files);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof.. make sure that all other calls pass the options properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tricky - the way we used to do it is only pass through options (and onProgress) through to one of the calls on batchUpload because otherwise the progress would reset in the middle (since we upload files first, then the top-level object). So we may want to only pass through onProgress to the file upload.

Can keep this as a fix for now though

@adam-maj
Copy link
Contributor Author

/release-pr

@adam-maj
Copy link
Contributor Author

/release-pr

@adam-maj adam-maj merged commit d608cea into main Sep 22, 2022
@adam-maj adam-maj deleted the am/progress branch September 22, 2022 22:15
@github-actions github-actions bot mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants