-
Notifications
You must be signed in to change notification settings - Fork 623
PayEmbed context cleanup, Add PayEmbedUI #2998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CodSpeed Performance ReportMerging #2998 will not alter performanceComparing Summary
|
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
==========================================
- Coverage 64.58% 64.56% -0.03%
==========================================
Files 758 758
Lines 52966 53057 +91
Branches 3092 3093 +1
==========================================
+ Hits 34208 34254 +46
- Misses 18093 18138 +45
Partials 665 665
*This pull request uses carry forward flags. Click here to find out more.
|
|
question: should we add a new component PayEmbedUI? |
|
TODO: test this |
jnsdls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM lets get tests in
PR-Codex overview
This PR enhances the wallet connection and chain switching functionalities in the codebase.
Detailed summary
switchChainfunction to components for seamless chain switchingactiveChainandaccountpropsuseActiveWalletChainanduseActiveAccounthooks